Python scanner for the first free port in a range












6












$begingroup$


I have a distributed application (YARN), which runs a WebApp.



This application use a default port to start (8008), before I start I need to check if port is in use.



A container may run in the same virtual machine, hence port may be in use.
(Max I have 4 containers in WebApp).



I created the following code which seem to work, but want to see if there are some clean ups/improvements suggested.



def port_in_use(port):
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
result = sock.connect_ex(('127.0.0.1', port))
if result == 0:
return True
else:
return False


def start_dashboard():
base_port = os.getenv('DASHBOARD_PORT_ENV_VAR', 8008)
scan_ports = True
attempts = 0
max_attempts = 10
while(scan_ports and attempts <= max_attempts):
if port_in_use(base_port):
base_port += 1
attempts += 1
else:
scan_ports = False
if attempts == max_attempts:
raise IOError('Port in use')
dashboard.configure(port=base_port)
dashboard.launch()









share|improve this question











$endgroup$

















    6












    $begingroup$


    I have a distributed application (YARN), which runs a WebApp.



    This application use a default port to start (8008), before I start I need to check if port is in use.



    A container may run in the same virtual machine, hence port may be in use.
    (Max I have 4 containers in WebApp).



    I created the following code which seem to work, but want to see if there are some clean ups/improvements suggested.



    def port_in_use(port):
    sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
    result = sock.connect_ex(('127.0.0.1', port))
    if result == 0:
    return True
    else:
    return False


    def start_dashboard():
    base_port = os.getenv('DASHBOARD_PORT_ENV_VAR', 8008)
    scan_ports = True
    attempts = 0
    max_attempts = 10
    while(scan_ports and attempts <= max_attempts):
    if port_in_use(base_port):
    base_port += 1
    attempts += 1
    else:
    scan_ports = False
    if attempts == max_attempts:
    raise IOError('Port in use')
    dashboard.configure(port=base_port)
    dashboard.launch()









    share|improve this question











    $endgroup$















      6












      6








      6


      1



      $begingroup$


      I have a distributed application (YARN), which runs a WebApp.



      This application use a default port to start (8008), before I start I need to check if port is in use.



      A container may run in the same virtual machine, hence port may be in use.
      (Max I have 4 containers in WebApp).



      I created the following code which seem to work, but want to see if there are some clean ups/improvements suggested.



      def port_in_use(port):
      sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
      result = sock.connect_ex(('127.0.0.1', port))
      if result == 0:
      return True
      else:
      return False


      def start_dashboard():
      base_port = os.getenv('DASHBOARD_PORT_ENV_VAR', 8008)
      scan_ports = True
      attempts = 0
      max_attempts = 10
      while(scan_ports and attempts <= max_attempts):
      if port_in_use(base_port):
      base_port += 1
      attempts += 1
      else:
      scan_ports = False
      if attempts == max_attempts:
      raise IOError('Port in use')
      dashboard.configure(port=base_port)
      dashboard.launch()









      share|improve this question











      $endgroup$




      I have a distributed application (YARN), which runs a WebApp.



      This application use a default port to start (8008), before I start I need to check if port is in use.



      A container may run in the same virtual machine, hence port may be in use.
      (Max I have 4 containers in WebApp).



      I created the following code which seem to work, but want to see if there are some clean ups/improvements suggested.



      def port_in_use(port):
      sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
      result = sock.connect_ex(('127.0.0.1', port))
      if result == 0:
      return True
      else:
      return False


      def start_dashboard():
      base_port = os.getenv('DASHBOARD_PORT_ENV_VAR', 8008)
      scan_ports = True
      attempts = 0
      max_attempts = 10
      while(scan_ports and attempts <= max_attempts):
      if port_in_use(base_port):
      base_port += 1
      attempts += 1
      else:
      scan_ports = False
      if attempts == max_attempts:
      raise IOError('Port in use')
      dashboard.configure(port=base_port)
      dashboard.launch()






      python python-3.x networking socket






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 2 days ago









      200_success

      130k17155419




      130k17155419










      asked 2 days ago









      spicyramenspicyramen

      307312




      307312






















          1 Answer
          1






          active

          oldest

          votes


















          8












          $begingroup$

          Your code has some incorrect assumptions.




          • an application may listen on a specific address/port combination; 127.0.0.1:port can be available while *:port is not.


          • an application may bind a port without listening. Connects will fail, but so will your own bind.


          • a firewall or other mechanism can interfere with connections, generating false positives in your scan.



          The reliable approach is to bind the port, just as your dashboard will, and then release it.



          result = sock.bind(('', port))
          sock.close()




          You'll need to catch the exception and this is a good opportunity to move the whole thing into a function. That will make the start_dashboard logic cleaner and get rid of boolean loop-terminator scan_ports. Just exit the loop by returning the answer.



          def next_free_port( port=1024, max_port=65535 ):
          sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
          while port <= max_port:
          try:
          sock.bind(('', port))
          sock.close()
          return port
          except OSError:
          port += 1
          raise IOError('no free ports')

          def start_dashboard():

          # pass optional second parameter "max_port" here, else scan until a free one is found
          port = next_free_port( os.getenv('DASHBOARD_PORT_ENV_VAR', 8008) )

          dashboard.configure(port=port)
          dashboard.launch()


          You can use netcat to make ports in-use for testing: nc -l -p 9999 will listen on port 9999; press control-C to end it.






          share|improve this answer











          $endgroup$













          • $begingroup$
            Thank you for the answer, check is local, so no firewall in place.
            $endgroup$
            – spicyramen
            2 days ago










          • $begingroup$
            I mean a host firewall, like iptables on Linux.
            $endgroup$
            – Oh My Goodness
            2 days ago












          • $begingroup$
            Sounds good, any recommendation for Python style? Thanks
            $endgroup$
            – spicyramen
            yesterday






          • 1




            $begingroup$
            the code can be a little shorter and clearer; see edits for a fleshed-out example.
            $endgroup$
            – Oh My Goodness
            yesterday






          • 1




            $begingroup$
            Thank you! Great sample
            $endgroup$
            – spicyramen
            yesterday











          Your Answer





          StackExchange.ifUsing("editor", function () {
          return StackExchange.using("mathjaxEditing", function () {
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          });
          });
          }, "mathjax-editing");

          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "196"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216037%2fpython-scanner-for-the-first-free-port-in-a-range%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          1 Answer
          1






          active

          oldest

          votes








          1 Answer
          1






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes









          8












          $begingroup$

          Your code has some incorrect assumptions.




          • an application may listen on a specific address/port combination; 127.0.0.1:port can be available while *:port is not.


          • an application may bind a port without listening. Connects will fail, but so will your own bind.


          • a firewall or other mechanism can interfere with connections, generating false positives in your scan.



          The reliable approach is to bind the port, just as your dashboard will, and then release it.



          result = sock.bind(('', port))
          sock.close()




          You'll need to catch the exception and this is a good opportunity to move the whole thing into a function. That will make the start_dashboard logic cleaner and get rid of boolean loop-terminator scan_ports. Just exit the loop by returning the answer.



          def next_free_port( port=1024, max_port=65535 ):
          sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
          while port <= max_port:
          try:
          sock.bind(('', port))
          sock.close()
          return port
          except OSError:
          port += 1
          raise IOError('no free ports')

          def start_dashboard():

          # pass optional second parameter "max_port" here, else scan until a free one is found
          port = next_free_port( os.getenv('DASHBOARD_PORT_ENV_VAR', 8008) )

          dashboard.configure(port=port)
          dashboard.launch()


          You can use netcat to make ports in-use for testing: nc -l -p 9999 will listen on port 9999; press control-C to end it.






          share|improve this answer











          $endgroup$













          • $begingroup$
            Thank you for the answer, check is local, so no firewall in place.
            $endgroup$
            – spicyramen
            2 days ago










          • $begingroup$
            I mean a host firewall, like iptables on Linux.
            $endgroup$
            – Oh My Goodness
            2 days ago












          • $begingroup$
            Sounds good, any recommendation for Python style? Thanks
            $endgroup$
            – spicyramen
            yesterday






          • 1




            $begingroup$
            the code can be a little shorter and clearer; see edits for a fleshed-out example.
            $endgroup$
            – Oh My Goodness
            yesterday






          • 1




            $begingroup$
            Thank you! Great sample
            $endgroup$
            – spicyramen
            yesterday
















          8












          $begingroup$

          Your code has some incorrect assumptions.




          • an application may listen on a specific address/port combination; 127.0.0.1:port can be available while *:port is not.


          • an application may bind a port without listening. Connects will fail, but so will your own bind.


          • a firewall or other mechanism can interfere with connections, generating false positives in your scan.



          The reliable approach is to bind the port, just as your dashboard will, and then release it.



          result = sock.bind(('', port))
          sock.close()




          You'll need to catch the exception and this is a good opportunity to move the whole thing into a function. That will make the start_dashboard logic cleaner and get rid of boolean loop-terminator scan_ports. Just exit the loop by returning the answer.



          def next_free_port( port=1024, max_port=65535 ):
          sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
          while port <= max_port:
          try:
          sock.bind(('', port))
          sock.close()
          return port
          except OSError:
          port += 1
          raise IOError('no free ports')

          def start_dashboard():

          # pass optional second parameter "max_port" here, else scan until a free one is found
          port = next_free_port( os.getenv('DASHBOARD_PORT_ENV_VAR', 8008) )

          dashboard.configure(port=port)
          dashboard.launch()


          You can use netcat to make ports in-use for testing: nc -l -p 9999 will listen on port 9999; press control-C to end it.






          share|improve this answer











          $endgroup$













          • $begingroup$
            Thank you for the answer, check is local, so no firewall in place.
            $endgroup$
            – spicyramen
            2 days ago










          • $begingroup$
            I mean a host firewall, like iptables on Linux.
            $endgroup$
            – Oh My Goodness
            2 days ago












          • $begingroup$
            Sounds good, any recommendation for Python style? Thanks
            $endgroup$
            – spicyramen
            yesterday






          • 1




            $begingroup$
            the code can be a little shorter and clearer; see edits for a fleshed-out example.
            $endgroup$
            – Oh My Goodness
            yesterday






          • 1




            $begingroup$
            Thank you! Great sample
            $endgroup$
            – spicyramen
            yesterday














          8












          8








          8





          $begingroup$

          Your code has some incorrect assumptions.




          • an application may listen on a specific address/port combination; 127.0.0.1:port can be available while *:port is not.


          • an application may bind a port without listening. Connects will fail, but so will your own bind.


          • a firewall or other mechanism can interfere with connections, generating false positives in your scan.



          The reliable approach is to bind the port, just as your dashboard will, and then release it.



          result = sock.bind(('', port))
          sock.close()




          You'll need to catch the exception and this is a good opportunity to move the whole thing into a function. That will make the start_dashboard logic cleaner and get rid of boolean loop-terminator scan_ports. Just exit the loop by returning the answer.



          def next_free_port( port=1024, max_port=65535 ):
          sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
          while port <= max_port:
          try:
          sock.bind(('', port))
          sock.close()
          return port
          except OSError:
          port += 1
          raise IOError('no free ports')

          def start_dashboard():

          # pass optional second parameter "max_port" here, else scan until a free one is found
          port = next_free_port( os.getenv('DASHBOARD_PORT_ENV_VAR', 8008) )

          dashboard.configure(port=port)
          dashboard.launch()


          You can use netcat to make ports in-use for testing: nc -l -p 9999 will listen on port 9999; press control-C to end it.






          share|improve this answer











          $endgroup$



          Your code has some incorrect assumptions.




          • an application may listen on a specific address/port combination; 127.0.0.1:port can be available while *:port is not.


          • an application may bind a port without listening. Connects will fail, but so will your own bind.


          • a firewall or other mechanism can interfere with connections, generating false positives in your scan.



          The reliable approach is to bind the port, just as your dashboard will, and then release it.



          result = sock.bind(('', port))
          sock.close()




          You'll need to catch the exception and this is a good opportunity to move the whole thing into a function. That will make the start_dashboard logic cleaner and get rid of boolean loop-terminator scan_ports. Just exit the loop by returning the answer.



          def next_free_port( port=1024, max_port=65535 ):
          sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
          while port <= max_port:
          try:
          sock.bind(('', port))
          sock.close()
          return port
          except OSError:
          port += 1
          raise IOError('no free ports')

          def start_dashboard():

          # pass optional second parameter "max_port" here, else scan until a free one is found
          port = next_free_port( os.getenv('DASHBOARD_PORT_ENV_VAR', 8008) )

          dashboard.configure(port=port)
          dashboard.launch()


          You can use netcat to make ports in-use for testing: nc -l -p 9999 will listen on port 9999; press control-C to end it.







          share|improve this answer














          share|improve this answer



          share|improve this answer








          edited yesterday

























          answered 2 days ago









          Oh My GoodnessOh My Goodness

          1,809314




          1,809314












          • $begingroup$
            Thank you for the answer, check is local, so no firewall in place.
            $endgroup$
            – spicyramen
            2 days ago










          • $begingroup$
            I mean a host firewall, like iptables on Linux.
            $endgroup$
            – Oh My Goodness
            2 days ago












          • $begingroup$
            Sounds good, any recommendation for Python style? Thanks
            $endgroup$
            – spicyramen
            yesterday






          • 1




            $begingroup$
            the code can be a little shorter and clearer; see edits for a fleshed-out example.
            $endgroup$
            – Oh My Goodness
            yesterday






          • 1




            $begingroup$
            Thank you! Great sample
            $endgroup$
            – spicyramen
            yesterday


















          • $begingroup$
            Thank you for the answer, check is local, so no firewall in place.
            $endgroup$
            – spicyramen
            2 days ago










          • $begingroup$
            I mean a host firewall, like iptables on Linux.
            $endgroup$
            – Oh My Goodness
            2 days ago












          • $begingroup$
            Sounds good, any recommendation for Python style? Thanks
            $endgroup$
            – spicyramen
            yesterday






          • 1




            $begingroup$
            the code can be a little shorter and clearer; see edits for a fleshed-out example.
            $endgroup$
            – Oh My Goodness
            yesterday






          • 1




            $begingroup$
            Thank you! Great sample
            $endgroup$
            – spicyramen
            yesterday
















          $begingroup$
          Thank you for the answer, check is local, so no firewall in place.
          $endgroup$
          – spicyramen
          2 days ago




          $begingroup$
          Thank you for the answer, check is local, so no firewall in place.
          $endgroup$
          – spicyramen
          2 days ago












          $begingroup$
          I mean a host firewall, like iptables on Linux.
          $endgroup$
          – Oh My Goodness
          2 days ago






          $begingroup$
          I mean a host firewall, like iptables on Linux.
          $endgroup$
          – Oh My Goodness
          2 days ago














          $begingroup$
          Sounds good, any recommendation for Python style? Thanks
          $endgroup$
          – spicyramen
          yesterday




          $begingroup$
          Sounds good, any recommendation for Python style? Thanks
          $endgroup$
          – spicyramen
          yesterday




          1




          1




          $begingroup$
          the code can be a little shorter and clearer; see edits for a fleshed-out example.
          $endgroup$
          – Oh My Goodness
          yesterday




          $begingroup$
          the code can be a little shorter and clearer; see edits for a fleshed-out example.
          $endgroup$
          – Oh My Goodness
          yesterday




          1




          1




          $begingroup$
          Thank you! Great sample
          $endgroup$
          – spicyramen
          yesterday




          $begingroup$
          Thank you! Great sample
          $endgroup$
          – spicyramen
          yesterday


















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216037%2fpython-scanner-for-the-first-free-port-in-a-range%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Identifying “long and narrow” polygons in with PostGISlength and width of polygonWhy postgis st_overlaps reports Qgis' “avoid intersections” generated polygon as overlapping with others?Adjusting polygons to boundary and filling holesDrawing polygons with fixed area?How to remove spikes in Polygons with PostGISDeleting sliver polygons after difference operation in QGIS?Snapping boundaries in PostGISSplit polygon into parts adding attributes based on underlying polygon in QGISSplitting overlap between polygons and assign to nearest polygon using PostGIS?Expanding polygons and clipping at midpoint?Removing Intersection of Buffers in Same Layers

          Masuk log Menu navigasi

          อาณาจักร (ชีววิทยา) ดูเพิ่ม อ้างอิง รายการเลือกการนำทาง10.1086/39456810.5962/bhl.title.447410.1126/science.163.3863.150576276010.1007/BF01796092408502"Phylogenetic structure of the prokaryotic domain: the primary kingdoms"10.1073/pnas.74.11.5088432104270744"Towards a natural system of organisms: proposal for the domains Archaea, Bacteria, and Eucarya"1990PNAS...87.4576W10.1073/pnas.87.12.4576541592112744PubMedJump the queueexpand by handPubMedJump the queueexpand by handPubMedJump the queueexpand by hand"A revised six-kingdom system of life"10.1111/j.1469-185X.1998.tb00030.x9809012"Only six kingdoms of life"10.1098/rspb.2004.2705169172415306349"Kingdoms Protozoa and Chromista and the eozoan root of the eukaryotic tree"10.1098/rsbl.2009.0948288006020031978เพิ่มข้อมูล